Fix -Wconversion warnings from gcc 8.5.0#4051
Conversation
|
I'd be interested to add a CI job running in |
982568c to
bb77ad0
Compare
|
I added a CI job, before the fix it fails as expected: |
kddnewton
left a comment
There was a problem hiding this comment.
If we're gonna do a whole thing here testing old GCCs, I don't want to just test this one specific version. Can we copy the stuff from ruby/ruby? Otherwise it feels very arbitrary.
|
@kddnewton That seems a lot more involved, could we merge this first? If you don't like the CI job I can remove it, but it seems better than nothing. For context, this is pretty much blocking a TruffleRuby release, as the release fails to build due to this. I would say it is not arbitrary, it is the oldest free RHEL-like distribution which is not EOL yet, see https://endoflife.date/almalinux |
7e6321e to
6069d67
Compare
|
I have removed the CI job as I don't want that to block this fix. |
|
The amount of jobs that are tested in ruby is huge, I agree that replicating that isn't really desirable. I think it's good enough to happen just on sync, I don't think not having it has done much harm yet. I'm ok with the added CI job. I don't really care which specific version it is or why it was chosen. It's within what ruby is testing and is more for the benefit of truffleruby than anything else. |
|
I'm also thinking whether testing so many compilers wouldn't add much CI time, there are 11 and that's just |
|
I can't imagine it would add too much time, because I don't think we would run the tests, just ensure it compiles without warnings/errors. |
Fixes #4048